Hi folks,
As we're always looking to streamline autotest and the offspring
projects (such as virt-test) development, one thing that occurred
to us is that code reviewing/patch management done through the mailing
list has disadvantages [1]:
1) Downloading/applying/reviewing patches is not very convenient. We
used to have a public patchwork instance that had to be disabled as we
decomissioned test.kernel.org. We have an internal patchwork instance,
but as the name says, it is internal, therefore we alienate people that
are not from Red Hat to conveniently download and apply patches.
2) Reviewing means a long thread of emails, with no visual cues to help
the reviewer, such as colors.
3) Following patch series is harder (you keep making searches on your
mailing list folders to look for previous versions of a patch and all that).
4) We already use github pull requests, so having to scan for new work
items on the ML and github is kind of an overhead.
I'd personally like to have something more gerrit
(http://code.google.com/p/gerrit/) like on github, but the pull requests
infrastructure is 'good enough' for what we want, and we don't get to
maintain infrastructure, which is a big "yay!" for us.
Therefore, I'd like to move to a model where we mandate pull requests
for contribution to autotest, virt tests and projects inside the
autotest umbrella. Of course, I don't want you guys to think I'm
shovelling this down your throats, so I'd like to hear if anybody feels
very strongly about it. Also, we could consider exceptions in cases like:
* I hate github so much that I can't stand using it and I think you are
all morons for even considering this OMG.
* I can't use github because, I don't know, my company forbids using web
browsers or send any requests to the port 80 or 443, or whatever.
So please, let us know what you think. By moving to a single,
concentrated point of review I believe we'll have less development
overhead and generally reduce stress levels of the maintainers.
Cheers,
Lucas
[1] At least for us, lame people that like web browsers, IDEs and
graphical email clients. I know, we are awful, but maybe you can bear
with us.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
