On 09/04/13 02:33 AM, Feng Yang wrote:
On 04/05/2013 04:28 AM, Lucas Meneghel Rodrigues wrote:
Hi folks,
As we're always looking to streamline autotest and the offspring
projects (such as virt-test) development, one thing that occurred
to us is that code reviewing/patch management done through the mailing
list has disadvantages [1]:
1) Downloading/applying/reviewing patches is not very convenient. We
used to have a public patchwork instance that had to be disabled as we
decomissioned test.kernel.org. We have an internal patchwork instance,
but as the name says, it is internal, therefore we alienate people
that are not from Red Hat to conveniently download and apply patches.
2) Reviewing means a long thread of emails, with no visual cues to
help the reviewer, such as colors.
3) Following patch series is harder (you keep making searches on your
mailing list folders to look for previous versions of a patch and all
that).
4) We already use github pull requests, so having to scan for new work
items on the ML and github is kind of an overhead.
I'd personally like to have something more gerrit
(http://code.google.com/p/gerrit/) like on github, but the pull
requests infrastructure is 'good enough' for what we want, and we
don't get to maintain infrastructure, which is a big "yay!" for us.
Therefore, I'd like to move to a model where we mandate pull requests
for contribution to autotest, virt tests and projects inside the
autotest umbrella. Of course, I don't want you guys to think I'm
shovelling this down your throats, so I'd like to hear if anybody
feels very strongly about it. Also, we could consider exceptions in
cases like:
* I hate github so much that I can't stand using it and I think you
are all morons for even considering this OMG.
* I can't use github because, I don't know, my company forbids using
web browsers or send any requests to the port 80 or 443, or whatever.
So please, let us know what you think. By moving to a single,
concentrated point of review I believe we'll have less development
overhead and generally reduce stress levels of the maintainers.
Hi Lucas
Just come back from holidays and PTO. So maybe reply this mail too later.
Already got your meaning from this email. But I think we'd better still
use emails (patchwork) and github at same times.
Github may cannot access in china sometimes. This used to happen before,
may happens again late. So I want to say that github is not stable for us.
Well, I'd guess this is a normal outage, like every other site
experiences. Sometimes the github pages and repos have some momentary
trouble, but in this regard, it is still pretty good.
send patch with emails has some disadvantage as you list. But it also
have some point make me still use it:
1. Full history is saved in emails. From Archives of the email list, I
can know all the information happened on this patch, such as the
difference between difference version and why we need a new version... .
With github seems some information will lost.
The information of the pull requests is still available, no history is
lost, commands in patches always keep their story.
2. With email all the patches will come to my client automatically. I
can comment and test the patch locally. At least I know the patch and
will review the patch summary. Does github can works in this way? If
we have to login web page to review patches. I think some people will
just ignore pull request. Less people care the patches, I think this is
not what we want.
Once you are subscribed to the project, you'll get notified over email
of the new patches. Downloading is also very easy, a lot easier than
saving the patches from a mail client. You just do:
curl https://github.com/autotest/autotest/pull/621.patch | git am
And test the patch and do whatever you want with it. That's *it*. I
don't get to be constantly irritated with badly formated patches as well.
As github is not always stable in china. Hope that we can still use
emails to make sure we can always connect with upstream.
Many people on your team (qzhou, ypu) already seem to use github very
productively (they send pull request and comment on patches every day),
so it doesn't seem that big of a deal. Please talk to them so they can
tell you of their experience.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
