On 04/05/2013 11:15 AM, Don Zickus wrote:
On Thu, Apr 04, 2013 at 05:28:10PM -0300, Lucas Meneghel Rodrigues wrote:
Therefore, I'd like to move to a model where we mandate pull
requests for contribution to autotest, virt tests and projects
inside the autotest umbrella. Of course, I don't want you guys to
think I'm shovelling this down your throats, so I'd like to hear if
anybody feels very strongly about it. Also, we could consider
exceptions in cases like:
Hi Lucas,
I'm confused. How would you provide feedback on a pull request?
So if I wanted to review someone's patches, I assume the new model is:
- I pull that person's 'pull request'
- review it offline
- to provide feedback, I ????
Not quite. The pull request is public, on the github page, you can look
at it in your browser, then you can click on any line of the patches and
write comments there (to write comments, you must be logged to your
github account). All the contributors, and people following autotest on
github get emails notifying of the new comment. Those people can then
write additional comments, just like on a mail thread, only there is a
single view of the entire discussion. Take for example:
https://github.com/autotest/virt-test/pull/242
The interesting part is that this entire pull request can be seen in
patch format
https://github.com/autotest/virt-test/pull/242.patch
So in fact, this already happens in all projects, it's just that we
don't mandate it so far. I assume you never saw these in action before,
right?
Let me know what you think.
Lucas
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
