----- Original Message -----
From: "Dennis Schridde" <[EMAIL PROTECTED]>
To: <warzone-dev@gna.org>
Sent: Monday, January 01, 2007 2:16 PM
Subject: Re: [Warzone-dev] Re: [Warzone-commits] r590 -
/trunk/src/projectile.c
Am Sonntag, 31. Dezember 2006 23:10 schrieb Troman:
>----- Original Message -----
>From: "Dennis Schridde" <[EMAIL PROTECTED]>
>To: <warzone-commits@gna.org>
>Sent: Sunday, December 31, 2006 8:54 PM
>Subject: [Warzone-commits] r590 - /trunk/src/projectile.c
>
>
>Author: devurandom
>Date: Sun Dec 31 20:54:46 2006
>New Revision: 590
>
>URL: http://svn.gna.org/viewcvs/warzone?rev=590&view=rev
>Log:
>Fix broken SCOURGEs yet again. Please check your patches before
>commiting...
>(SCOURGEs exploded immediately when launched.)
Strange, scourges worked for me when I tested,
Well they didn't work when I checked it out, because of this change:
http://svn.gna.org/viewcvs/warzone/trunk/src/projectile.c?rev=587&view=diff&r1=587&r2=586&p1=trunk/src/projectile.c&p2=/trunk/src/projectile.c
which I stripped from his patches, because it broke the scourges...
Devurandom, I think I tested this patch throughly enough with all in all
more than a day dedicated to reviewing and testing. Whenever I make mistakes
and we are not making something of nothing I'm ready to stand to them, but I
hope you understand checking each weapon after each patch is something none
of us can afford.
If this bug was re-introduced this could be due to the conflicts in
projectile.c which is still a bummer and I'm glad you fixed it, but I don't
think this is a reason enough to groundlessly accuse anyone of being
careless out of the blue because of that.
I even did some candidate
screenshots with that revision we _might_ want to use, although some post
processing might be required.
http://user.supradigital.org/troman/screnshots/
BTW please also check the order of patches before commiting, I had to
resolve quite some conflicts in the projectile.c before commiting patch
from 27.12.2006.
Was that to me?
Did I commit some patch which wasn't applied fully?
Or do you mean that I didn't commit the Multi-Target patch before commiting
other patches? That was on purpose, because Watermelon told me that you
were
working with him on that patch, because you want to give orders to each of
the turrets, while his patch only allowed to give orders to the droid as a
whole.
This looks like a work of a confusion-devil. I didn't even have a look at
the patch by that time.
I solely expressed my worries about weapon functions relying on bitfields as
return value someday, which was probably the premice for the inclusion of
the int->bool return value conversion in the patch and my only contribution
to it (except for some modifications before commiting it).
Troman
--Dennis
_______________________________________________
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
