Follow-up Comment #18, bug #8522 (project wesnoth):
OK, sorry to belabor such a minor issue, but I just don't agree. :p
1) generating a user-visible decription that should be translateable from one
that should NOT be marked translateable seems to encourage incorrect
translatability for one or the other. So I don't see this as an elegant
feature, but rather an odd backwards compatibility that should probably be
removed.
2) I see what you're trying to do with the AI, but I don't buy the
"undesirable split" argument. If you want AiWML to support SUF then that is
good. But, unit::matches_filter match is slow and should not be performed
unless it is specified. At that point it could look up the unique id, and
thus the internal mechanic would be invisible to the WML coder.
3) While the gains from an integer as unique-id might be negligible in this
case, I think it could be a significant improvement in the long term. In
particular, if it could replace the location based unit map which is
currently a source of invalidated iterator errors, expensive unit copy
operations, and location-based assumptions.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?8522>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
