Follow-up Comment #14, bug #8522 (project wesnoth):
I had actually considered that. The problem is such an implementation is
effectively what caused the original bug. Wesnoth doesn't recognize the
difference of loading a unit from a scenario file and a save game file. WML
in general recognizes that "" is undefined. So, even if when you recruited
the unit, it didn't get a user_description (as was happening with the
Undead), if you saved the unit and reloaded, it will automagically give it a
name. Making it clever enough to recognize the difference between a saved
unit and a scenario would be too kludgey in my opinion to be worth it.
I am not strongly opposed to making it so that user_description is required
for all units in a scenario, but I do think that such a change would be a
significant enough impact that I would want to poll more devs before making
it. It would have the nice feature of cleaning up the C++ a bit and removing
an implicit WML rule that is pretty ugly. On the other hand, it would break a
lot of scenarios objectives and other messages to the player. If I was doing
things from scratch, I would do it this way, but I hesitate to soft-break
things like this after the fact.
The solution that I did implement I think is less intrusive given current
scenarios, but I could be wrong. I think it is fine to require a
user_description in scenario based units. I also think that it is fine to
require race/unit designers to choose names for the name generator, even if
the choice is to call them all " ". The choice between these two options
depends on which is the greater burden on WML maintainters. I suspect that
the latter is less work to maintain as the name generator is defined once per
race, but the description tag is used in every scenario specific special
unit.
So, I guess what I am saying is that if you still would prefer to change it
from the current implementation, I would suggest we expand the conversation
of who is involved by opening a discussion in the developers section of the
forum. I know that IRC is good for making quick decisions, but it tends to
have a very short/inconsistent memory. If there is strong feeling against
the current solution and in favor of making user_descriptions mandatory, I
will be happy to clean out the autogeneration of the user_description within
the C++ entirely.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?8522>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
