Follow-up Comment #13, bug #8522 (project wesnoth):
Ok, you convinced me about description. It seems it's use as the identifier
is justified and all good, and that a scenario which makes multiple units
have the same description is to blame for any trouble originating from that.
So yes, I'll agree that it's ok to autogenerate a unique identifier into the
description if none is specified. Now, that only leaves the question of what
to do about generating the player-visible name (user_description) from
description (if no explicit user_description is given): personally, I
wouldn't mind dropping the auto-generation here. You're supposed to _always_
supply a user_description for units whose names are used in any
player-visible way (for translation purposes), because description is not
supposed to be marked as translatable. At least in mainline no campaign
should atm rely on the auto-generation. Some UMC probably does, but I'd vager
only the ones that are otherwise hopeless already.
Now, this most likely depends on how the code works (which I don't know much
about), but would it be possible to do this: when creating a unit in a
scenario, check if a description= is given but no user_description=. If yes,
auto-generate the user_description= from the description=. Also, when
recruiting a unit (or spawning one with generate_description=) check whether
the unit would get a random name as it's user_description=, and if not,
auto-generate user_description="". If yes, then it doesn't need to be
touched. So basically, the code would be smart and auto-generate the
user_description from description if it makes some sense to do so (when there
is an explicitly given description) and auto-generate an empty string as the
user_description if not (when there would only be a generated description to
auto-generate from). I think this would be my most preferred behaviour, with
dropping the autogeneration as a good second. What do you think, feasible or
too messy?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?8522>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
