On Thu, Mar 20, 2008 at 07:04:11AM -0500, Bruno Wolff III wrote: > On Thu, Mar 20, 2008 at 00:28:40 +0100, > jeremy rosen <[EMAIL PROTECTED]> wrote: > > thx for doing the work on trunk, thix warning thing is going to be a bit > > painfull at fist, but big benefits in the long run...
Yes thanks for fixing it. > Yeah, I kept waiting for someone to fix it so it would build again here. > But probably I am the only one who has update access and is using gcc 4.3 > on my main machine (via Fedora Rawhide). So I finally just went through > and took a look at each warning. > > > I am not sure it's worth poirting to 1.4 though > > > > "if it ain't broken" and all that... I agree as well. > That's kind of what I figured. The 1.4 branch doesn't even have the warning > to error promotion on by default. Yes I only added this feature to trunk and didn't port it to 1.4 nor did I intent to. Seeing that it causes problems with GCC-4.3 means it was a good decision ;-) > However there were 3 (I think) changes that appeared to be actual bugs > and one use of an anonymous typedef to define constants which seems to > be nonstandard. Assuming they are also in the 1.4 branch, should I > backport those changes? (Those would be the ones where I noted a 'semantic > change'.) If they're bugs I'd say they should be fixed in 1.4. Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
