> However there were 3 (I think) changes that appeared to be actual bugs
Thanks for the precedence fix of r24874, it's indeed the wanted semantic (some people even skip the "!= 0" but that seems less clean) The check itself is not critical (maybe even useless, but not the GetMouseState call). It was added because SDL sometimes do strange things with drag&drop in special cases, like dragging outside the window. So it's supposed to avoid problems if we miss the release event. From the precedence error, it suspect that it's also possible that pressing different buttons simultaneously while dragging an unit could cause unwanted behavior, but all seems to work fine, at least when combining the 3 standard buttons. I think that we can port it to 1.4. I am not aware of bugs here, but I assume that the drag&drop is not very used. So better have a correct and gcc 4.3-compilable line than a half-broken one working only by luck.
_______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
