Anomie added a comment.
In T198341#5022412 <https://phabricator.wikimedia.org/T198341#5022412>, @daniel wrote: > In T198341#5021347 <https://phabricator.wikimedia.org/T198341#5021347>, @BPirkle wrote: > > > - includes/search/SearchPostgres.php > > > odd stuff, maybe @anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo? Note in the PostgreSQL schema the "text" table is named "pagecontent". That was done in rSVN15791 <https://phabricator.wikimedia.org/rSVN15791>; I don't know why quoting wasn't just used instead. The plan for T164898 <https://phabricator.wikimedia.org/T164898>/T191231 <https://phabricator.wikimedia.org/T191231> includes renaming it back to "text". It looks like that file needs some #technical-debt <https://phabricator.wikimedia.org/tag/technical-debt/> cleanup to use the IDatabase querying methods rather than building SQL strings directly, but that alone would probably be out of scope here. What is in scope is that it's trying to search directly against the `text` table, having added an extra column for that purpose, and will need to be converted to use a `searchindex` table like MySQL does. >> - tests/phpunit/includes/ActorMigrationTest.php > > I think Anomie siad somehwre that the rev_text_id stuff should just be removed, right? Correct. That was just above in T198341#5020970 <https://phabricator.wikimedia.org/T198341#5020970>. > I recommend doing separate patches for all of these. Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes. SearchPostgres.php seems complicated enough that it would make sense to do it separately though, since it's going to involve a schema change for PG plus probably significant edits to the file itself. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle, Anomie Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
