Anomie added a comment.
> I'll also remove any references to the other two fields [text.old_id and archive.ar_text_id] Note that text.old_id references are probably sill valid in low-level code like HistoryBlob.php and SqlBlobStore. > - maintenance/populateContentTables.php This maintenance script is intended to be called during update when rev_text_id still exists in the database, specifically to migrate data //out of// rev_text_id before dropping the column. At some point it'll probably gain a check near line 190 <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/fe3a04748bfa37a43872b8fff83565d37074807f/maintenance/populateContentTables.php#190> something like if ( !$this->dbw->fieldExists( $table, $fields['text_id'], __METHOD__ ) ) { $this->output( "No need to populate, $table.{$fields['text_id']} field does not exist\n" ); return; } Whether that's done during this task or T184615 <https://phabricator.wikimedia.org/T184615>, I have no real opinion. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle, Anomie Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
