Addshore added a comment.
Indeed we are only talking about the mobile term box right now. Looking at the 2 Gerrit changes I think something like #1 would be best (I haven't seen the hook in #2 used at all anywhere). Although #1 could en changed to register a new parser option called wb-termbox for example, default value null, used in cache key and when termbox is rendered set it to 2. I believe that would leave the current cache keys as they are / only change the cache key for renders with the termbox, but it would be worth checking that. I haven't dug into all of the code, but is shouldRenderTermbox always the right thing to be checking? I guess the cache avoidence when the SSR is down etc happens somewhere else? The future should also be considered, and what is the behaviour is we complete termbox for desktop, roll it out everywhere, but then need to turn the feature off / shouldRenderTermbox = false. Is turning the feature off going to result in all pcache entities essentially being lost, as it probably shouldn't. But maybe this should be something we think about for the desktop release rather than just mobile, but we don't want to forget. TASK DETAIL https://phabricator.wikimedia.org/T228978 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, Addshore Cc: WMDE-leszek, Addshore, Tarrow, Jakob_WMDE, Aklapper, Michael, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
