User "NeilK" posted a comment on MediaWiki.r92200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92200#c20043 Commit summary:
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: I don't understand, under what conditions can this problem occur? There is not supposed to be any check for uniqueness of file contents in the UploadStash. As you mentioned it is very likely to get re-uploads, even from multiple people, and this is not necessarily a mistake at this stage. Files just need to have unique names and generally the unique name is set by the API client anyway, and if not you have a good function to create a unique name. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
