User "Catrope" posted a comment on MediaWiki.r92200. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92200#c20813 Commit summary:
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: Ian suggests it's possible to supply non-random keys: <blockquote> This was a problem when we were using the content hash as the filekey. The key is a unique string as of r92269, so it's only relevant if the user-supplied key is non-unique. That's a pretty rare edge case, but I figured since it was possible I'd leave the code in. </blockquote> I agree that race conditions in the random keys can be considered impossible. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
