User "Catrope" posted a comment on MediaWiki.r92200. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92200#c20815 Commit summary:
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: I'm personally fine with somewhat ungraceful handling of a very rare edge case based on duplicate random keys for which the probability they will ever happen in the remaining lifetime of the universe is very low, as long as the consequences aren't too confusing. Just throwing an error is fine, overwriting things is not. But if you're gonna write code to handle this case and resolve it in a nice way, you should at least write correct code :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
