User "Catrope" posted a comment on MediaWiki.r92200. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92200#c20803 Commit summary:
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: Similarly, removeFile() is vulnerable to a race condition if the file is taken over in between checking ownership and deleting it. It's much easier to just to a conditional <code>DELETE</code> and put the ownership criterion in the <code>WHERE</code> clause. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
