User "NeilK" posted a comment on MediaWiki.r92200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92200#c20841 Commit summary:
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: We're close to being able to remove the $key parameter entirely. The only way (as far as I can tell) that $key is ever necessarily non-null is the case of includes/job/UploadFromUrlJob.php. In fact UploadFromUrlJob.php is already outmoded, it's making assumptions that the session is where the stashed files are. I believe it can be simplified so that it doesn't pass a key at all, and instead returns the key generated. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
