Hi John & Joe,
or better still just merge r5211 from ^/branches/wsjtx .
Either way the warning is harmless.
73
Bill
G4WJS.
On 13/04/2015 16:32, John Nelson wrote:
> Hi Joe,
>
> This error occures in mainwindow:
>
> ....wsjtx/mainwindow.cpp:988:11: warning: taking the absolute value of
> unsigned type
> 'unsigned long long' has no effect [-Wabsolute-value]
> if (std::llabs (working_frequency - m_dialFreq) < 10000)
>
> I mentioned this to Bill and he corrected this in wsjtx and it would be good
> idea to replace the line above with his correction:
>
> auto offset = m_dialFreq > working_frequency ? m_dialFreq -
> working_frequency : working_frequency - m_dialFreq;
>
> so that the code snippet reads:
>
> auto working_frequency = frequencies->data (frequencies->index (row,
> 0)).value<Frequency> ();
> auto offset = m_dialFreq > working_frequency ? m_dialFreq -
> working_frequency : working_frequency - m_dialFreq;
> if (offset < 10000u)
> {
> valid = true;
> }
>
> --- John G4KLA
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
