On 12/04/2017 05:15, Black Michael wrote:
I take it you're saying there's something wrong there but somehow I don't see it....

Hi Mike,

I gave an example that did not work correctly with the last patch you provided. Now you provide a different patch which does seem to fix that example but complain that I did something wrong!

Your new patch also doesn't work for existing valid, correctly encoded and decoded messages, e.g.:

C:\Users\bill>\test-install\wsjtx-dev\Debug\bin\jt65code.exe "za/k1abc g0xyz"
     Message                 Decoded                Err? Type
--------------------------------------------------------------------------
 1.  ZA/K1ABC G0XYZ          ZA/K1ABC G0XY            *  6:    Free text

Packed message, 6-bit symbols  52 20 28  5  8 60 60 45 32  8 22 12

Information-carrying channel symbols
    7 54 42 59 59 17  1 57 34 62 49 38 25  1 39 23 58 34  6 50 30
   32  1 40 50 46 59 11 16  3 50 18 56 63 30 48 20 41  9 28 53 43
   37 18 12 36 40 26 58 45 15 24  7 29 61 21 16 53 44 27 36 12 10

Fixing this issue cannot be approached by trial and error. We have the tools to test the encoding and decoding end to end, perhaps a bash script to test all possible message types (not all possible messages, just the ones necessary to give 100% code coverage) would be a better place to start.

73
Bill
G4WJS.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to