[ 
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702543#comment-13702543
 ] 

Hitesh Shah commented on YARN-727:
----------------------------------

  - Use MRJobConfig.MR_APPLICATION_TYPE instead of "MAPREDUCE".
  - documentation for ApplicationClientProtocol#getApplications does not seem 
to be correct. It does not mention usage in terms of filtering based on 
criteria defined in the request object. It mentions that it returns only 
running applications - is that correct? 
      - Likewise in YarnClient. Doc changes. 

{code}
+   * Get a report (ApplicationReport) of Applications
+   * about the given applicationTypes in the cluster.
{code}
  - Above should be reworded to something along the lines of getting reports of 
applications matching the given application types.

  - In YarnClientImpl, should code be re-used across the 2 getApplication* 
functions?
  - why does APP_TYPE_CMD need to be in YarnCLI and not in ApplicationCLI? 
  - "param appTypes" - please add more docs for app types in various places 
where this is an argument
  - In GetApplicationsRequestPBImpl, what happens if setApplicationTypes is 
called twice. The first with a non-empty set and the second call with a null.









  
                
> ClientRMProtocol.getAllApplications should accept ApplicationType as a 
> parameter
> --------------------------------------------------------------------------------
>
>                 Key: YARN-727
>                 URL: https://issues.apache.org/jira/browse/YARN-727
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.1.0-beta
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>            Priority: Blocker
>         Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch, 
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.16.patch, 
> YARN-727.17.patch, YARN-727.18.patch, YARN-727.1.patch, YARN-727.2.patch, 
> YARN-727.3.patch, YARN-727.4.patch, YARN-727.5.patch, YARN-727.6.patch, 
> YARN-727.7.patch, YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission, 
> getAllApplications should be able to use this string to query for a specific 
> application type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to