[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703383#comment-13703383
]
Hitesh Shah commented on YARN-727:
----------------------------------
{code}
- * <p>The interface used by clients to get a report of all Applications
+ * <p>The interface used by clients to get a report of Applications
+ * matching the given application types defined in the request object
* in the cluster from the <code>ResourceManager</code>.</p>
{code}
- Might be better to say matching the filters defined by the <code> or @link
of GetApplicationsRequest object and put in a reference for them to refer to it
via @see. If not, this doc will change every time a new filter is added.
{quote}
It mentions that it returns only running applications - is that correct?
{quote}
- In the previous set of comment reviews, there was a point about running
applications. Will the RM never return an application that has not launched or
has already been finished?
YarnClient and ApplicationClientProtocol have different function names - in one
case, it is getApplicationsList and in the other, getApplications. We should
try and stick to getApplications in all places if possible.
testHelpCommand is only testing whether a function is called but not verifying
the contents printed out.
{code}
GetApplicationsRequestPBImpl#setApplicationTypes(Set<String> applicationType)
{code}
- What if the object is initialized and the first call made is
"setApplicationTypes(null)"?
- you should refer to GetApplicationsResponsePBImpl implementation to see
what is different.
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Priority: Blocker
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.16.patch,
> YARN-727.17.patch, YARN-727.18.patch, YARN-727.19.patch, YARN-727.1.patch,
> YARN-727.2.patch, YARN-727.3.patch, YARN-727.4.patch, YARN-727.5.patch,
> YARN-727.6.patch, YARN-727.7.patch, YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
