[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703598#comment-13703598
]
Xuan Gong commented on YARN-727:
--------------------------------
bq.testHelpCommand is only testing whether a function is called but not
verifying the contents printed out.
The PrintWrite object used in printOutHelp is different from that used in
ApplicationCLI/TestApplicationCLI. It is from HelpFormatter.class. And it will
be recreated every time when we try to print out the command usage. Unlike the
PrintWrite object used in ApplicationCLI/TestApplicationCLI, I can not simply
spy the object and get the content into a string variable to do the
verification.
Other comments will be addressed in the new patch
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Priority: Blocker
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.16.patch,
> YARN-727.17.patch, YARN-727.18.patch, YARN-727.19.patch, YARN-727.1.patch,
> YARN-727.2.patch, YARN-727.3.patch, YARN-727.4.patch, YARN-727.5.patch,
> YARN-727.6.patch, YARN-727.7.patch, YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
