[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703640#comment-13703640
]
Hitesh Shah commented on YARN-727:
----------------------------------
{code}
+ return getApplications(new HashSet<String>());
{code}
- shouldn't it use null instead of an empty object?
No modifications to TestYarnClient even though YarnClient has changed?
- YarnCLI seems to be using only one flavor of the api. The other api in
YarnClient[Impl] not being tested?
'setApplicationTypes(Set<String> applicationType)' - should be applicationTypes
'repeated string application_type' should be 'repeated string application_types'
addApplicationTypesToProto api seems to indicate add and not set.
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Priority: Blocker
> Attachments: YARN-727.10.patch, YARN-727.11.patch, YARN-727.12.patch,
> YARN-727.13.patch, YARN-727.14.patch, YARN-727.15.patch, YARN-727.16.patch,
> YARN-727.17.patch, YARN-727.18.patch, YARN-727.19.patch, YARN-727.1.patch,
> YARN-727.20.patch, YARN-727.2.patch, YARN-727.3.patch, YARN-727.4.patch,
> YARN-727.5.patch, YARN-727.6.patch, YARN-727.7.patch, YARN-727.8.patch,
> YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
