[ https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590410#comment-16590410 ]
Naganarasimha G R commented on YARN-7863: ----------------------------------------- Thanks [~cheersyang] for the detailed clarification, {quote} PCs are not associated with resource, so it's like an extra check after all other checks are done. Scheduler still calculates how much resource available in a partition for a given queue, assign resource from a node in this partition to a request, but if PC is not satisfied then the allocation proposal will be rejected. et {quote} Agree PC's are not directly involved with resource, But IIUC with the new API :_SchedulingRequest_ for allocation of containers has only PC as the way to specify partitions which is tied with resource . This is the reason i had my concerns with the OR. Let me go through the code with new API and understand whether Partition is handled for all scenarios. I was always under the impression that there will be a constraint explicitly for the Partition based on which resources are accounted ( USED, PENDING , RESERVED etc...). But if its internal to the constraint which is also OR'd with others i am not completely sure its addressing . {quote}Partition in PC is not ready, to be honest, I am not sure if everything is align with existing label-based scheduling. I suggested in YARN-8015 to open a separate task for further enhance that. {quote} Let me too try to understand the PC and new api modifications in detail and then share my feedback in that Jira and anyway its out of the scope for this jira. > Modify placement constraints to support node attributes > ------------------------------------------------------- > > Key: YARN-7863 > URL: https://issues.apache.org/jira/browse/YARN-7863 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Sunil Govindan > Assignee: Sunil Govindan > Priority: Major > Attachments: YARN-7863-YARN-3409.002.patch, > YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch, > YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch, > YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch, > YARN-7863.v0.patch > > > This Jira will track to *Modify existing placement constraints to support > node attributes.* -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org