[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592740#comment-16592740
]
Weiwei Yang commented on YARN-7863:
-----------------------------------
Thanks [~sunilg], the patch looks good. To make code changes independent and
incremental, I've created YARN-8715 to further make the allocation tags in this
optional.
There are some minor issues.
# Some of unit test failures are related
# There are some unused imports in classes
# PlacementConstraintParser#TargetExprType can be removed
# PlacementConstraintsUtil has "import *"
# PlacementConstraintParser#getAttributeOpCode, can we throw an illegal
argument exception if the op is something else than EQ/NE?
# I think we need more UT to cover node-attributes, but that can be added in a
follow up Jira
Thanks
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch,
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch,
> YARN-7863-YARN-3409.005.patch, YARN-7863-YARN-3409.006.patch,
> YARN-7863-YARN-3409.007.patch, YARN-7863-YARN-3409.008.patch,
> YARN-7863-YARN-3409.009.patch, YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
