[
https://issues.apache.org/jira/browse/YARN-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376602#comment-14376602
]
Junping Du commented on YARN-3040:
----------------------------------
Hi [~zjshen], thanks for the patch! I am still reviewing the patch but have
some quick comments so far:
{code}
+ public static String generateDefaultClusterIdBasedOnAppId(
+ ApplicationId appId) {
+ return "cluster_" + appId.getClusterTimestamp();
+ }
{code}
It seems appId's ClusterTimestamp comes from RM and get changed everytime RM
get restart. I think here we need a ClusterID that can keep consistent across
from RM restarts. Isn't it? Or applications get submitted to the same cluster
could get different ClusterID just because RM failed over which shouldn't be
users' expectation. Suggest to add a configuration for user to input a
specified ClusterID or it generate default (and variable) value for test
purpose.
{code}
+ rpc getTimelienCollectorContext (GetTimelineCollectorContextRequestProto)
returns (GetTimelineCollectorContextResponseProto);
{code}
One typos here and other places, "Timelien" should be "Timeline".
{code}
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Vector;
+import java.util.*;
{code}
We shouldn't do this which could load unnecessary classes.
{code}
+ * The aggregator needs to get the context information including user, flow
{code}
aggregator => collector
> [Data Model] Make putEntities operation be aware of the app's context
> ---------------------------------------------------------------------
>
> Key: YARN-3040
> URL: https://issues.apache.org/jira/browse/YARN-3040
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3040.1.patch, YARN-3040.2.patch
>
>
> Per design in YARN-2928, implement client-side API for handling *flows*.
> Frameworks should be able to define and pass in all attributes of flows and
> flow runs to YARN, and they should be passed into ATS writers.
> YARN tags were discussed as a way to handle this piece of information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
