[
https://issues.apache.org/jira/browse/YARN-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378946#comment-14378946
]
Sangjin Lee commented on YARN-3040:
-----------------------------------
bq. It will check if the tag starts with "TIMELINE_FLOW_ID_TAG:", and then if
the value is empty,
"TIMELINE_FLOW_ID_TAG:".substring("TIMELINE_FLOW_ID_TAG".length() + 1) will
return an empty value. It shouldn't throw IndexOutOfBoundsException. But it
seems there's no need to add an empty env, I'll change the code accordingly.
Ack. I was thrown off because the code was like
{code}
if (tag.startsWith(TAG + ":")) {
String value = tag.substring(TAG.length() + 1);
}
{code}
It works because the "+1" is really for the semi-colon.
LGTM overall.
> [Data Model] Make putEntities operation be aware of the app's context
> ---------------------------------------------------------------------
>
> Key: YARN-3040
> URL: https://issues.apache.org/jira/browse/YARN-3040
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3040.1.patch, YARN-3040.2.patch, YARN-3040.3.patch,
> YARN-3040.4.patch
>
>
> Per design in YARN-2928, implement client-side API for handling *flows*.
> Frameworks should be able to define and pass in all attributes of flows and
> flow runs to YARN, and they should be passed into ATS writers.
> YARN tags were discussed as a way to handle this piece of information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
