[
https://issues.apache.org/jira/browse/YARN-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377984#comment-14377984
]
Junping Du commented on YARN-3040:
----------------------------------
Some additional comments:
{code}
<property>
+ <description>The YARN cluster ID.</description>
+ <name>yarn.resourcemanager.cluster-id</name>
+ <value>yarn_cluster</value>
+ </property>
{code}
I would prefer something like "yarn.cluster.id" because this id is for
identifying YARN cluster rather than ResourceManager. It should keep consistent
across RMs (active and standby) get switch over. Also other names like:
RM_CLUSTER_ID, DEFAULT_RM_CLUSTER_ID, we should use YARN_CLUSTER_ID instead.
{code}
@@ -208,7 +211,11 @@ public void testDSShell(boolean haveDomain, String
timelineVersion)
if (timelineVersion.equalsIgnoreCase("v2")) {
String[] timelineArgs = {
"--timeline_service_version",
- "v2"
+ "v2",
+ "--flow",
+ "test_flow_id",
+ "--flow_run",
+ "12345678"
};
{code}
Can we add a test case that without specifying flow_id and flow_run_id and v2
timeline service still can work? In my understanding, these info will still be
optional for applications. So we should make sure these info is nullable in
launching applications and other following flows.
> [Data Model] Make putEntities operation be aware of the app's context
> ---------------------------------------------------------------------
>
> Key: YARN-3040
> URL: https://issues.apache.org/jira/browse/YARN-3040
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3040.1.patch, YARN-3040.2.patch, YARN-3040.3.patch
>
>
> Per design in YARN-2928, implement client-side API for handling *flows*.
> Frameworks should be able to define and pass in all attributes of flows and
> flow runs to YARN, and they should be passed into ATS writers.
> YARN tags were discussed as a way to handle this piece of information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
