Naganarasimha G R commented on YARN-2740:

Thanks for the review [~wangda],
bq. Should we throw exception when distributedConfiguration enabled for 
removeClusterNodeLabels? remove will change labels on node, after removed, node 
heartbeat with the removed partition will be identified as error, it seems 
reasonable to me. Admin should be able to control "valid-partitions" in the 
Actually dint get completely your opinion about throw exception when 
distributedConfiguration enabled for removeClusterNodeLabels;  Did you want to 
throw ? if you want to allow admin to remove ClusterNodeLabels  then there is 
one case which i can see potential problem:  Assume NM informs RM with a valid 
node label "x" through HB/Resgistration and then admin removes x from cluster 
node labels. But this is not communicated back to NM and NM will not send 
labels as part of HB *unless there is change in labels in NM side*. So NM is 
not aware of "x" being removed at all. I agree we need to allow Admin to 
control valid partitions but in that case we need to add some logic in RM to 
request NM to resubmit labels.  Please provide ur views. 
Will correct other issues as part of next patch.

> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch, 
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.

This message was sent by Atlassian JIRA

Reply via email to