[
https://issues.apache.org/jira/browse/YARN-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499033#comment-14499033
]
Wangda Tan commented on YARN-2740:
----------------------------------
Thanks for your quick update [~Naganarasimha].
bq. Actually dint get completely your opinion about throw exception when
distributedConfiguration enabled for removeClusterNodeLabels; Did you want to
throw ?
I think it's better now prevent admin remove clusterNodeLabel when distributed
enabled.
bq. if you want to allow admin to remove ClusterNodeLabels then there is one
case which i can see potential problem: Assume NM informs RM with a valid node
label "x" through HB/Resgistration and then admin removes x from cluster node
labels. But this is not communicated back to NM and NM will not send labels as
part of HB unless there is change in labels in NM side. So NM is not aware of
"x" being removed at all. I agree we need to allow Admin to control valid
partitions but in that case we need to add some logic in RM to request NM to
resubmit labels. Please provide ur views.
I think it's not a big problem, NM doesn't need to know "x" being removed, the
logic should be, NM reports label, and RM allocate according to label, NM
should just move on if adding label failed as what we done in YARN-2495. My
opinion here is not add extra RM->NM communicate.
I will review patch again when we decided above one.
> ResourceManager side should properly handle node label modifications when
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2740
> URL: https://issues.apache.org/jira/browse/YARN-2740
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Naganarasimha G R
> Fix For: 2.8.0
>
> Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch,
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch,
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch,
> YARN-2740.20150417-1.patch
>
>
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do
> heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
