[
https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533373#comment-14533373
]
Hadoop QA commented on YARN-644:
--------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 38s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 37s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 4s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 5m 59s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 42m 6s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731255/YARN-644.03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ab5058d |
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7775/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7775/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7775/console |
This message was automatically generated.
> Basic null check is not performed on passed in arguments before using them in
> ContainerManagerImpl.startContainer
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-644
> URL: https://issues.apache.org/jira/browse/YARN-644
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Omkar Vinit Joshi
> Assignee: Varun Saxena
> Priority: Minor
> Labels: BB2015-05-TBR, newbie
> Attachments: YARN-644.001.patch, YARN-644.002.patch, YARN-644.03.patch
>
>
> I see that validation/ null check is not performed on passed in parameters.
> Ex. tokenId.getContainerID().getApplicationAttemptId() inside
> ContainerManagerImpl.authorizeRequest()
> I guess we should add these checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
