[ 
https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533886#comment-14533886
 ] 

Varun Saxena commented on YARN-644:
-----------------------------------

Ok...Thats correct. We should not be using these constants outside package.

> Basic null check is not performed on passed in arguments before using them in 
> ContainerManagerImpl.startContainer
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-644
>                 URL: https://issues.apache.org/jira/browse/YARN-644
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.7.0
>            Reporter: Omkar Vinit Joshi
>            Assignee: Varun Saxena
>            Priority: Minor
>              Labels: BB2015-05-RFC
>         Attachments: YARN-644.001.patch, YARN-644.002.patch, 
> YARN-644.03.patch, YARN-644.04.patch, YARN-644.05.patch
>
>
> I see that validation/ null check is not performed on passed in parameters. 
> Ex. tokenId.getContainerID().getApplicationAttemptId() inside 
> ContainerManagerImpl.authorizeRequest()
> I guess we should add these checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to