[
https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533866#comment-14533866
]
Li Lu commented on YARN-644:
----------------------------
Hi [~varun_saxena], thanks for working on this! The patch is mostly good, just
one quick thing:
{code}
+ public static final String INVALID_NMTOKEN_MSG = "Invalid NMToken";
+ public static final String INVALID_CONTAINERTOKEN_MSG =
+ "Invalid ContainerToken";
{code}
Why do we need these two strings to be public? I think default would be good
for the unit tests, or am I missing anything here? Thanks!
> Basic null check is not performed on passed in arguments before using them in
> ContainerManagerImpl.startContainer
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-644
> URL: https://issues.apache.org/jira/browse/YARN-644
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: Omkar Vinit Joshi
> Assignee: Varun Saxena
> Priority: Minor
> Labels: BB2015-05-RFC
> Attachments: YARN-644.001.patch, YARN-644.002.patch,
> YARN-644.03.patch, YARN-644.04.patch
>
>
> I see that validation/ null check is not performed on passed in parameters.
> Ex. tokenId.getContainerID().getApplicationAttemptId() inside
> ContainerManagerImpl.authorizeRequest()
> I guess we should add these checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
