[
https://issues.apache.org/jira/browse/YARN-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533448#comment-14533448
]
Li Lu commented on YARN-644:
----------------------------
Hi [~varun_saxena], thanks for the patch! Asserting on the content of the
exception message may unnecessarily couple the exception handling message with
the test, which makes future changes harder. Maybe we'd like to provide some
central place for those exception message constants? Thanks!
> Basic null check is not performed on passed in arguments before using them in
> ContainerManagerImpl.startContainer
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-644
> URL: https://issues.apache.org/jira/browse/YARN-644
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Omkar Vinit Joshi
> Assignee: Varun Saxena
> Priority: Minor
> Labels: BB2015-05-TBR, newbie
> Attachments: YARN-644.001.patch, YARN-644.002.patch, YARN-644.03.patch
>
>
> I see that validation/ null check is not performed on passed in parameters.
> Ex. tokenId.getContainerID().getApplicationAttemptId() inside
> ContainerManagerImpl.authorizeRequest()
> I guess we should add these checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
