[
https://issues.apache.org/jira/browse/YARN-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560272#comment-15560272
]
Allen Wittenauer commented on YARN-5704:
----------------------------------------
bq. function you are referring to is static currently
Frankly, that's the least of this patch's problems. It features almost all of
the issues that currently plague c-e:
1. Lack of a unit test. Covered.
2. Useless abstraction:
{code}
int is_docker_support_enabled() {
return is_feature_enabled(DOCKER_SUPPORT_ENABLED_KEY,
DEFAULT_DOCKER_SUPPORT_ENABLED);
}
int is_tc_support_enabled() {
return is_feature_enabled(TC_SUPPORT_ENABLED_KEY,
DEFAULT_TC_SUPPORT_ENABLED);
}
{code}
3. Variable declaration in the middle:
{code}
char *end_ptr = NULL;
{code}
> Provide config knobs to control enabling/disabling new/work in progress
> features in container-executor
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5704
> URL: https://issues.apache.org/jira/browse/YARN-5704
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Affects Versions: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-5704-branch-2.8.001.patch, YARN-5704.001.patch
>
>
> Provide a mechanism to enable/disable Docker and TC (Traffic Control)
> functionality at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
