[
https://issues.apache.org/jira/browse/YARN-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560712#comment-15560712
]
Sidharta Seethana commented on YARN-5704:
-----------------------------------------
[~aw], again : my reason for testing this manually was that most of the changes
were to main.c - that was the only way to test if enabling/disabling these
features worked in the first place. The fact that the function was static ( and
the fact that the patch was already committed to trunk/branch-2) were the
reasons for filing a separate JIRA for the tests to keep things clean - I was
not using that as a reason to not add tests. container-executor in general
needs a complete overhaul - for testability if not anything else.
There is no disagreement that bad practices should not be further propagated -
but we disagree on 'where variables should be declared in C code' being one
among them.
> Provide config knobs to control enabling/disabling new/work in progress
> features in container-executor
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5704
> URL: https://issues.apache.org/jira/browse/YARN-5704
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Affects Versions: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-5704-branch-2.8.001.patch, YARN-5704.001.patch
>
>
> Provide a mechanism to enable/disable Docker and TC (Traffic Control)
> functionality at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
