[
https://issues.apache.org/jira/browse/YARN-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560552#comment-15560552
]
Sidharta Seethana commented on YARN-5704:
-----------------------------------------
/cc [~chris.douglas], [~vinodkv]
[~aw], going back and forth discussing new concerns every time is not
productive. Do you have more concerns with this patch or is the list above
complete? Regarding your comments above :
# I explained already that most of the changes are in main.c which cannot be
tested via test-container-executor - I'll go ahead add tests for the function
you referred to.
# I don't believe it is a "useless abstraction" - those functions provide
useful, less error-prone shorthands.
# “In the middle” ? This variable is declared at the beginning of a new scope.
Even if it weren’t, declaring variables ‘near’ where they are needed is common
practice and is a widely used GNU extension. If this is a problem, we could use
static checking as part of our build or add the {{-ansi}} and {{-pedantic}}
compiler flags (and in the process break code that has existed for 5+ years).
> Provide config knobs to control enabling/disabling new/work in progress
> features in container-executor
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5704
> URL: https://issues.apache.org/jira/browse/YARN-5704
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Affects Versions: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-5704-branch-2.8.001.patch, YARN-5704.001.patch
>
>
> Provide a mechanism to enable/disable Docker and TC (Traffic Control)
> functionality at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
