[
https://issues.apache.org/jira/browse/YARN-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560583#comment-15560583
]
Allen Wittenauer commented on YARN-5704:
----------------------------------------
Look, if I was super concerned about those other problems in the patch, I would
have brought them up in the first post. I just found it really off putting that
your major reason for not building a unit test was because it was declared
*static*. It's like... really? If we take that to it's logical conclusion we
just declare all of our utility functions as static and remove all the unit
tests.
bq. and in the process break code that has existed for 5+ years
... which is why I said...
bq. It features almost all of the issues that currently plague c-e
Just because the old code follows bad practices doesn't mean that new code
should. c-e not being ANSI C compliant *is* a problem, BTW.
> Provide config knobs to control enabling/disabling new/work in progress
> features in container-executor
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5704
> URL: https://issues.apache.org/jira/browse/YARN-5704
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Affects Versions: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-5704-branch-2.8.001.patch, YARN-5704.001.patch
>
>
> Provide a mechanism to enable/disable Docker and TC (Traffic Control)
> functionality at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
