[
https://issues.apache.org/jira/browse/YARN-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561309#comment-15561309
]
Chris Douglas commented on YARN-5704:
-------------------------------------
Thanks for working on this, [~sidharta-s].
As part of the followup patch, please also avoid using {{strcat}} when printing
the usage can be separated into multiple statements. Avoids allocating a buffer
we need to track for overflow. Sorry, I hadn't noticed that earlier.
bq. If we take that to it's logical conclusion we just declare all of our
utility functions as static and remove all the unit tests.
That takes this heuristic well past its logical conclusion, but it'll be
addressed in YARN-5717.
bq. [Variable declaration in the middle] Just because the old code follows bad
practices doesn't mean that new code should. c-e not being ANSI C compliant is
a problem, BTW.
If this creates portability problems that makes sense, though VS is the only C
compiler I know of that (until recently?) doesn't support most of C99.
Initializing variables when they're declared can avoid accidents, particularly
over long LCE methods. Are any platforms this could target restricted to ANSI C
compilers?
Requiring that new patches use ANSI C, without making the rest of LCE
compliant, adds a touchy manual step for committers and helps no users. If
there are restrictions on the subset of C this should use, the compiler needs
to enforce them.
> Provide config knobs to control enabling/disabling new/work in progress
> features in container-executor
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5704
> URL: https://issues.apache.org/jira/browse/YARN-5704
> Project: Hadoop YARN
> Issue Type: Task
> Components: yarn
> Affects Versions: 2.8.0, 3.0.0-alpha1, 3.0.0-alpha2
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-5704-branch-2.8.001.patch, YARN-5704.001.patch
>
>
> Provide a mechanism to enable/disable Docker and TC (Traffic Control)
> functionality at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
