Benjamin Reed commented on ZOOKEEPER-29:

this looks really good.

you build an ackToString String, but don't use it. it's probably a left over 

i'm wondering if it is a good idea to let the QuorumVerifier to be changed 
while the service is up. perhaps we should throw an exception in that case.

could you document the configuration of the hierarchical QuorumVerifier? it 
would also be good to expand the description in the javadoc at the top of 

> Flexible quorums
> ----------------
>                 Key: ZOOKEEPER-29
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-29
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, 
> ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, ZOOKEEPER-29.patch
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1938782&group_id=209147&atid=1008547

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to