[ https://issues.apache.org/jira/browse/ZOOKEEPER-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699661#action_12699661 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-29: ------------------------------------------------- > you build an ackToString String, but don't use it. it's probably a left over > debugging. I forgot to add to add the string to the message following it. I have fixed it in the new patch. > i'm wondering if it is a good idea to let the QuorumVerifier to be changed > while the service > is up. perhaps we should throw an exception in that case. If I interpret your comment correctly, you're concerned about calls to QuorumPeer::setQuorumVerifier after initialization. As far as I can tell, we have the same issue with other variables. For example, if we change the quorum port on-the-fly, we might get into trouble. Actually, changing the QuorumVerifier on-the-fly doesn't seem to cause a server to stop operating. The only issue I can see is that a server may have a different notion of quorums, but I think this can happen even if we enforce that we set the QuorumVerifier only during initialization. We guarantee that servers have consistent configuration files, right? If you think this is a general issue with initialization, we should perhaps open a different jira and address this problem there? > could you document the configuration of the hierarchical QuorumVerifier? it > would also be > good to expand the description in the javadoc at the top of > QuorumHierarchical? Done. Let me know if you think it is sufficient. > Flexible quorums > ---------------- > > Key: ZOOKEEPER-29 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-29 > Project: Zookeeper > Issue Type: New Feature > Components: server > Reporter: Patrick Hunt > Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, > ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, ZOOKEEPER-29.patch, > ZOOKEEPER-29.patch, ZOOKEEPER-29.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1938782&group_id=209147&atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.