Wichert Akkerman wrote:
Previously yuppie wrote:
Wichert Akkerman wrote:
Previously yuppie wrote:
- figure out if we can make acl_users an utility
User folders, or their plugins, seem to have a tendency to rely on
self.REQUEST so that is probably not going to work.

MembershipTool depends on acl_users

MemberDataTool, RegistrationTool, DiscussionTool and CachingPolicyManager depend on MembershipTool

I did a very quick grep over my plone 3.0 tree:

* GroupUserFolder uses self.REQUEST in listUsersAndRoles

* The PAS CookieHandler uses self.REQUEST in its login method

* PlonePAS uses self.REQUEST in its credentialsChanged method. The
  PlonePAS memberdata and grouptool use self.REQUEST._hold in their
  wrap methods.

We would also have to audit all PAS plugins.

So far I tried to decide which tool depends on self.REQUEST and which not. Maybe we need a more fine grained approach:

MembershipTool doesn't depend on all methods of acl_users, not all user folder methods depend on self.REQUEST. IStandardUserFolder has not all the methods, but an interface that adds _doAddUser(), getUserById() and userFolderDelUsers() should be sufficient. Maybe that set of methods specified by a user folder utility interface doesn't depend on self.REQUEST.

If that doesn't work, we can try the same with the MembershipTool: If not all methods of IMembershipTool work without self.REQUEST, we still can use a subset IMembershipUtility.

I'm optimistic these issues can be resolved one way or the other. But I don't want to spend more time on this before five.localsitemanager is better tested. I hope the current state of the CMF 2.1 branch is sufficient for testing five.localsitemanager with Plone and KSS.

Cheers, Yuppie

Zope-CMF maillist  -  Zope-CMF@lists.zope.org

See http://collector.zope.org/CMF for bug reports and feature requests

Reply via email to