Dear Gustav,
Thank you so much for you feedback.
I just distributed a new mail with an explanation for the patches..
Sorry if it arrives too late..
I will answers your questions here below.
Once again, sorry for the bad timing.
Ciao,
Maurizio
From: Gustaf Neumann [mailto:neum...@wu-wien.ac.at]
Sent: 05 August 2011 14:23
To: AOLserver Discussion
Cc: Maurizio Martignano
Subject: Re: [AOLSERVER] Aolserver Progress - Some few examples....
Dear Maurizio and all...
i have updated cvs on sourceforge with most of your patches. A few points
are questionable (see below).
For me, it is still unclear, why 4.5.1 worked for you, but not the head
version not. As far i can see,
all socket usages were int the same way in 4.5.1, the variable triggers in
nsd.h was defined like this at least since 2004. Maybe it was "luck" that
the win version worked in 4.5.1 (different memory layout, different
compilers / compiler options, ...)
[MM] No.. Just Alzheimer. Me. When I first did the compilation I spotted the
problem and I fixed it by changing int trigger[2] into SOCKET trigger[2].
Then I forgot completely about it.. Then the issue showed up again... when I
downloaded the code again..
A few comments to the patches (i have omitted these):
nsd/nsmain.c
+#ifndef _WIN32
Tcl_Finalize();
+#endif
[MM] As simple as that: TCL_Finalize never ends on Windows, so it prevents
the process/service to stop properly.
===> If one does no Tcl_Finalize() one introduces a memory leak.
[MM] The process/service is about to end anyhow. I believe that mo matter
what the poor process/service does all its memory will be released by the
OS. So this is not an issue.
nsproxy/nsproxy.c
- Tcl_FindExecutable(argv[0]);
===> The call to Tcl_FindExecutable() is required (at least in Tcl 8.5),
otherwise tcl will crash (at least under unix like operating systems)
[MM] Not my change, please look at my newest email and sorry if I cause you
some inconvenience.
same situations for the following changes.. Sorry...
+#define uint32_t unsigned long
+#define uint16_t unsigned short
+
+typedef void * caddr_t;
===> These defines should be most probably within an #ifdef
static void
-FatalExit(char *func)
+NSP_FatalExit(char *func)
===> What's wrong with the static name FatalExit()?
-static Proc *firstClosePtr = NULL;
+static Proc *firstClosePtr;
===> What's wrong with the initialization of the static variable?
[MM] absolutely nothing.. May be my bad usage of patch, again apologies.
I have not updated the nsproxy changes, since these need more work.
[MM]
Perfect
-gustaf neumann
On 05.08.11 08:14, Maurizio Martignano wrote:
Dear all,
here you are with a "first" patch file and the zip containing the code base
I'm using.
The "nspd" module requires more work, but I'm not using it.
The files in the zip archive do compile and seems to be working Windows 32
and Windows 64.
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to
<lists...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
