On Wed, 28 Dec 2022 at 16:44, <l...@pibf.de> wrote: > I have integrated the code from Lo Valvo and Drago > and extended it to planes yz and zx.
Great, thanks. > 1. "|| beta > 1e10" > There was a small error in the function biarc in > file: src/emc/task/emccanon.cc. > I added the condition "beta > 1e10" because without > the file "Ruota_dentata #1=1.ngc" is not working. > The value of 1E10 is only guessed. There are pre-defined "Fuzz" values available, maybe one of those would be appropriate? https://github.com/LinuxCNC/linuxcnc/blob/2.8/src/libnml/posemath/posemath.h#L709 > My debug code is still there and I fear to violate > your coding style a lot. > https://linuxcnc.org/docs/devel/html/code/style-guide.html > I suggest to use indent. It's probably better to match the surrounding code than to match the coding style. > 3. Parameter #1 > To select the methods from ECME14.pdf NICU, NICL and NICC > see: http://wiki.linuxcnc.org/cgi-bin/wiki.pl?NURBS > #1 in front of G6.2 is used. > See for example: /nc_files/nurbs/G6/Curva_Chitarra #1=1.ngc > Excerpt: > #1=1 > G6.2 X59.171 Y23.693 R46.5833333333333 K0 P5 F290 > > Do you agree with this? No, I can't say that I like that particularly. Why not use an extra (optional) letter in the G6.2 command? > 5: Interp::nurbs_reset_global_variables(); > There are static variables in > /src/emc/rs274ngc/interp_convert.cc line 142. " setup_pointer settings) //!< pointer to machine settings" ? I think that those settings are meant to be persistent. What problem does it cause? > 6. G6.3 > This is not used. Please check _gees are correct. > Is Gx is the right modal group? /* 60 */ -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,15,-1,-1,-1,-1,-1,-1,-1,-1,-1, Looks like no G6 codes are valid? -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1912 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
