Re: [gentoo-dev] Changing policy about -Werror

[Richard Yao]

> On Sep 10, 2018, at 5:18 PM, Chí-Thanh Christopher Nguyễn 
> <chith...@gentoo.org> wrote:
> 
> Fabian Groffen schrieb:
>>> On 09-09-2018 11:22:41 -0400, Richard Yao wrote:
>>> -Werror has caught bugs that could have resulted in data loss in ZFS in the 
>>> past thanks to it being built in userspace as part of zdb. So it is useful 
>>> for integrity too, not just security (although arguably, integrity is part 
>>> of security).
>> This is a misconception, as jer already pointed out.  Instead:
>> -Werror has forced you to take notice of problems that could have
>> resulted in data loss in ZFS ...
> 
> But in general it doesn't say when or how the problems became acute. Assuming 
> that the warning isn't bogus, it could have been the code relying on 
> undefined behavior, and the compiler changing the semantics of such behavior, 
> and introducing an accompanying warning at the same time.
This is precisely why every warning is considered a bug and -Werror is set when 
USE=debug is in use.
> 
> 
> Best regards,
> Chí-Thanh Christopher Nguyễn
>