Hi, Cameron Shorter wrote: > Andreas, > I'd be interested to discuss this with you, maybe at the next team > meeting. > > I think the most of the catalog widgets are generally applicable. >
Cameron, here is a quick review: SelectLayerFromContext.js: line 47: var metadataWidget = config.objects.layerMetadata; This is a hard-coded reference to a config object, which we really do not want to have in core widgets. This should be made configurable. SaveContext.js: This widget should replace (and be renamed to) the existing lib/widget/Save.js. It does exactly the same, only it restores the popup feature this one had before 1.5alpha2. BUT: it uses the kind of popups that will be blocked by every popup blocker. The old Save widget showed the popup only when a popupWindowName property was defined. This new widget should behave the same way. Also, I do not like the modelSaved listener being added in the trigger function of the control, because this happens on every button click. Instead, this should be done in a widget function on the "init" event. > You are right that we need to update config.xsd. If those issues will be fixed, I'm +1 for adding those widgets to the trunk. Regards, Andreas. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
