Roald, Roald de Wit wrote: >> * modifications to MapPaneOL >> * add the popup stuff from SaveContext.js to lib/widget/Save.js >> * your modified LayerControl.js is also a candidate for lib/widget, >> except for the showLayerMetadata method. There is still a >> hard-coded reference to config.objects.layerMetadata in it, so why >> don't you put the whole showLayerMetadata stuff in the >> LayerMetadata widget and trigger it with a "layerMetadata" event >> from your custom LayerControl.xsl? >> > > This is were I need some discussion: it is easy to make the metadata > part of LayerControl and I'll do that. For the XSL part of it, i'd like > to keep that separate, so an app developer can choose to plug another > XSL in if he/she wants to. Would you agree with this or prefer to have > it hardcoded in the LayerControl XSL? >
As I said: if you use a custom XSL for LayerControl, you can trigger arbitrary events as a result of user interaction (e.g. pressing a button), and those can be handled by separate tools and widgets. So I am in favour of doing things in a clean MVC manner and trigger events instead of putting tons of functions in a single widgets and call them directly, with the hassle of having to define with which widgets/tools they interact. > We've developed other things that can be added to the LayerControl like > 'maxFeatures' (for WFS) and 'Save GML' (as Cameron pointed out). Even if > approved to be added to LayerControl, you see that things will get a bit > full in there. > > We then get to a situation where you want to control what you show in > your LayerControl, either as: > - configurable options within the LayerControl in the config.xml > - separate widgets that plug themselves into the LayerControl > In our MVC environment, many widgets and tools can interact without knowing each other. They just have to trigger events that others listen to. This is the path that I would take. Or in your words: separate widgets that plug themselves into the context model (not the LayerControl). > OK, OK... np. :-) But, are you sure the popup will be blocked? Doesn't > happen in FF2 (checked whether I allowed for popups). > That is the concern of the app developer. But we had that in previous versions, and someone might miss it. And now that you have it again, why not restore this feature? Regards, Andreas. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
