Roald de Wit wrote:
> Hello,
>
> I've just checked in a new version of the catalog (r3872) with the
> following changes (come from our CGDI-IP project):
>
> - Added Layer Metadata: is in a separate widget now (and still hardcoded
> Andreas!), but is a proof of concept. Want to reference XSL from
> LayerControl widget.
> - Added a loading spinner per layer (needed to change MapPaneOL.js and
> have made a local copy).
>   
very nice addition of yours. Glad you were able to include this.
> - Merged SelectLayerFromContext into LayerControl (removes a lot of
> double XSL stuff)
>   
Nice.
It seems the column showing WMS/WFS has been removed. If it is easy, I 
suggest putting that back in, ideally with a config option to have the 
column visible or not. (This is probably non-trivial, so we can leave it 
for a future release)
> - Optional title for LayerControl widget (nice)
> - Made all image references default in LayerControl, so they don't have
> to be specified anymore (but can be overridden)
>
> Please have a look at examples/catalog/ and tell me what you'd like to
> see in 1.5 and where I can improve things.
>
> I was thinking of having 2 features for LayerControl: copyToTargetModel
> and moveToTargetModel (instead of addLayer). In the latter case the
> layer will be removed from the current model after it has been added to
> the target model. Any suggestions?
>   
My suggestion: Keep It Simple. Us programmers always want to cover all 
possible options, but it is more important that users can understand the 
functionality easily.
Therefore only support copyToTargetModel.
> The SaveContext widget was just for debugging purposes. I don't intend
> to work on that one and will remove it from the demo soon. 
>   
I think we should keep the SaveContext, unless there is already a tool 
which does the same thing.

I can't see the "Save GML" button in the LayerControl widget, or the 
"Max Features" limit button. Is there a reason for removing them? (Too 
complicated is a reasonable answer)
> Kind regards,
>
> Roald
>
> On Thu, 2008-02-21 at 01:45 +0100, Andreas Hocevar wrote:
>   
>> SelectLayerFromContext.js:
>> line 47:    var metadataWidget = config.objects.layerMetadata;
>> This is a hard-coded reference to a config object, which we really do 
>> not want to have in core widgets. This should be made configurable.
>>
>> SaveContext.js:
>> This widget should replace (and be renamed to) the existing 
>> lib/widget/Save.js. It does exactly the same, only it restores the popup 
>> feature this one had before 1.5alpha2. BUT: it uses the kind of popups 
>> that will be blocked by every popup blocker. The old Save widget showed 
>> the popup only when a popupWindowName property was defined. This new 
>> widget should behave the same way.
>> Also, I do not like the modelSaved listener being added in the trigger 
>> function of the control, because this happens on every button click. 
>> Instead, this should be done in a widget function on the "init" event.
>>
>>     
>>> You are right that we need to update config.xsd.
>>>       
>> If those issues will be fixed, I'm +1 for adding those widgets to the trunk.
>>
>>
>> Regards,
>> Andreas.
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> mapbuilder-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
>>     
>
>   


-- 
Cameron Shorter
Geospatial Systems Architect
Tel: +61 (0)2 8570 5050
Mob: +61 (0)419 142 254

Think Globally, Fix Locally
Commercial Support for Geospatial Open Source Solutions
http://www.lisasoft.com/LISAsoft/SupportedProducts.html


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel

Reply via email to