Hi Roald,

thanks for your efforts!

Roald de Wit wrote:

> - Added a loading spinner per layer (needed to change MapPaneOL.js and
> have made a local copy).
>   

I am in favour of that. You can make this modification in 
lib/widget/MapPaneOL.

> Please have a look at examples/catalog/ and tell me what you'd like to
> see in 1.5 and where I can improve things.
>   

    * modifications to MapPaneOL
    * add the popup stuff from SaveContext.js to lib/widget/Save.js
    * your modified LayerControl.js is also a candidate for lib/widget,
      except for the showLayerMetadata method. There is still a
      hard-coded reference to config.objects.layerMetadata in it, so why
      don't you put the whole showLayerMetadata stuff in the
      LayerMetadata widget and trigger it with a "layerMetadata" event
      from your custom LayerControl.xsl?
    * OwsContext.js can be removed from your example, it is the same as
      the trunk version


> I was thinking of having 2 features for LayerControl: copyToTargetModel
> and moveToTargetModel (instead of addLayer). In the latter case the
> layer will be removed from the current model after it has been added to
> the target model. Any suggestions?
>   

As Cameron said: keep it simple.

> The SaveContext widget was just for debugging purposes. I don't intend
> to work on that one and will remove it from the demo soon. 
>   

But please add the popup stuff to lib/widget/Save.js, because this was 
there before 1.5alpha2.


Regards,
Andreas.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel

Reply via email to