On Thu, Feb 28, 2008 at 11:07 AM, Roald de Wit
<[EMAIL PROTECTED]> wrote:
> Hi Andreas,
>
>
> On Wed, 2008-02-27 at 14:21 +0100, Andreas Hocevar wrote:
> > I am in favour of that. You can make this modification in
> > lib/widget/MapPaneOL.
>
> Great, I'll do that!
> Can you explain one thing to me: which of these 2 is better to do and
> why:
>
> this.model.setParam("loadLayerStart", layerId);
> or
> this.model.callListeners("loadLayerStart", layerId);
this.model.setParam(name, value), sets a variable in the model, which
can later be accessed by model.getParam(param);
setParam() also calls callListeners(name, value).
If you only want to trigger an event, user callListeners(), otherwise
use setParam().
>
> ?
>
> > * modifications to MapPaneOL
> > * add the popup stuff from SaveContext.js to lib/widget/Save.js
> > * your modified LayerControl.js is also a candidate for lib/widget,
> > except for the showLayerMetadata method. There is still a
> > hard-coded reference to config.objects.layerMetadata in it, so why
> > don't you put the whole showLayerMetadata stuff in the
> > LayerMetadata widget and trigger it with a "layerMetadata" event
> > from your custom LayerControl.xsl?
>
> This is were I need some discussion: it is easy to make the metadata
> part of LayerControl and I'll do that. For the XSL part of it, i'd like
> to keep that separate, so an app developer can choose to plug another
> XSL in if he/she wants to. Would you agree with this or prefer to have
> it hardcoded in the LayerControl XSL?
Keep it simple initially, especially for this first iteration.
(Although I do like your idea of plugins as something we can look into later)
>
> Something else:
>
> We've developed other things that can be added to the LayerControl like
> 'maxFeatures' (for WFS) and 'Save GML' (as Cameron pointed out). Even if
> approved to be added to LayerControl, you see that things will get a bit
> full in there.
Keep it simple.
>
> We then get to a situation where you want to control what you show in
> your LayerControl, either as:
> - configurable options within the LayerControl in the config.xml
> - separate widgets that plug themselves into the LayerControl
>
> What path should we choose if we were to give the user some control over
> what is shown in the LayerControl?
>
>
> > * OwsContext.js can be removed from your example, it is the same as
> > the trunk version
> I will do that, thanks.
>
>
> > But please add the popup stuff to lib/widget/Save.js, because this was
> > there before 1.5alpha2.
> OK, OK... np. :-) But, are you sure the popup will be blocked? Doesn't
> happen in FF2 (checked whether I allowed for popups).
>
> Regards,
>
> Roald
>
>
> --
> Roald de Wit
> Software Engineer
> [EMAIL PROTECTED]
>
> Commercial Support for Open Source GIS Software
> http://lisasoft.com/LISAsoft/SupportedProducts/
>
>
> -------------------------------------------------------------------------
>
>
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> mapbuilder-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
>
--
Cameron Shorter
Geospatial Systems Architect
Tel: +61 (0)2 8570 5050
Mob: +61 (0)419 142 254
Think Globally, Fix Locally
Commercial Support for Geospatial Open Source Solutions
http://www.lisasoft.com/LISAsoft/SupportedProducts.html
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
mapbuilder-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
